-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(new): command to npm link to angular-cli
#778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Yea, it was me and I approve with this commit |
It's me, I'm the same person, I approve with the commits |
ui.writeLine(chalk.green('Successfully linked to angular-cli.')); | ||
}) | ||
.catch(function (/*error*/) { | ||
ui.writeLine(chalk.red( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all fits in one line, like the chalk.green
above.
Last comment: In the |
add `--link-cli` command to link newly generated project to the global `angular-cli` package. reduces `ng new ...` command time with about 50%
angular-cli
angular-cli
Can you rebase? I'll merge this when it's ready (or rebase myself later today). |
I was away, sorry. |
Looks like the npm link is done after the npm install which defeats the purpose as it does not reduce install time nor size of node_modules. @filipesilva @monojack @monodnb Please review. As a workaround, i use:
Woud love to have it in one command. Thanks. |
With from @aecz 's process, link-cli is a large improvement in project setup time. Might it be worthwhile to make that process the default you get with "ng new"? In other words, make the fast path default, and the slow (but more correct, from a version-locking point of view) optional? It seems this really improves the CLI user experience. (Currently running ng-new is pretty fast on my Macbook, not so fast on most of Windows machines.) |
Made a new pull request to address this |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
add
--link-cli
command to link newly generated project to the globalangular-cli
package. reduces
ng new ...
command time with about 50%